zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lujiefsi <...@git.apache.org>
Subject [GitHub] zookeeper issue #495: ZOOKEEPER-3007:Potential NPE in ReferenceCountedACLCac...
Date Wed, 25 Apr 2018 02:27:00 GMT
Github user lujiefsi commented on the issue:

    https://github.com/apache/zookeeper/pull/495
  
    @phunt 
    I got it. I have found all "deserialize" root caller and callsite postion:
    (1)QuorumPeer#1208,#1154,#1152,#1182,#1154,#1194,#1195: their code have same format:
    ` try {
                       //root caller
                        } catch (Exception e) {
                            LOG.warn("Unexpected exception",e);
           }
    } `   
    So i think the RuntimeException in the patch  is ok in here
    (2)QuorumPeer#860,852:  there is another "throw new RuntimeException" at #520. So i think
the RuntimeException in the patch  is ok in here
    (3)ZooKeeperServerMain#64  SnapshotFormatter#53 : these two caller are main function,
when run into RuntimeException , it will exit, I am not sure the "RuntimeException" in the
patch  whether is ok in here.



---

Mime
View raw message