zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From phunt <...@git.apache.org>
Subject [GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count
Date Tue, 24 Apr 2018 23:17:02 GMT
Github user phunt commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/501#discussion_r183907088
  
    --- Diff: src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java ---
    @@ -167,6 +167,8 @@ public void testValidateStatOutput() throws Exception {
             line = in.readLine();
             Assert.assertTrue(Pattern.matches("^Mode: .*$", line));
             line = in.readLine();
    +        Assert.assertTrue(Pattern.matches("^Fsync threshold exceeded: \\d+$", line));
    --- End diff --
    
    That's pretty ugly, esp. if there are changes in the future.
    
    Given the Monitor command is available since 3.4.0 and handles (documented) such changes
correctly perhaps we should just add this to monitor and not add it to stat. If a user wants
the additional information they can use mntr instead.
    
    What do you think @nkalmar ?
    
    The other benefit is that it will integrate into 3.4 more easily - i.e. fully b/w compat
w/o any worries.


---

Mime
View raw message