zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From phunt <...@git.apache.org>
Subject [GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...
Date Mon, 23 Apr 2018 23:22:23 GMT
Github user phunt commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/466#discussion_r183565848
  
    --- Diff: src/contrib/monitoring/ganglia/zookeeper_ganglia.py ---
    @@ -213,7 +213,13 @@ def metric_init(params=None):
             'zk_max_file_descriptor_count': {'units': 'descriptors'},
             'zk_followers': {'units': 'nodes'},
             'zk_synced_followers': {'units': 'nodes'},
    -        'zk_pending_syncs': {'units': 'syncs'}
    +        'zk_pending_syncs': {'units': 'syncs'},
    +        'zk_last_proposal_size': {'units': 'ms'},
    --- End diff --
    
    Should these values be in "ms"? Seems like a cut/paste typo? I suspect you rather "bytes"
- right?


---

Mime
View raw message