zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rakeshadr <...@git.apache.org>
Subject [GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...
Date Sat, 21 Apr 2018 06:38:22 GMT
Github user rakeshadr commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/466#discussion_r183201618
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
    @@ -106,10 +104,10 @@ public String toString() {
         private final HashSet<LearnerHandler> learners =
             new HashSet<LearnerHandler>();
     
    -    private final ProposalStats proposalStats;
    +    private final BufferStats bufferStats;
    --- End diff --
    
    Could you use "proposalStats" variable name instead of "bufferStats", thats more readable.


---

Mime
View raw message