zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...
Date Thu, 19 Apr 2018 10:12:58 GMT
Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/466#discussion_r182698169
  
    --- Diff: src/java/main/org/apache/zookeeper/server/command/MonitorCommand.java ---
    @@ -75,9 +79,9 @@ public void commandRun() {
                 print("synced_followers", leader.getForwardingFollowers().size());
                 print("pending_syncs", leader.getNumPendingSyncs());
     
    -            print("last_proposal_size", leader.getProposalStats().getLastProposalSize());
    -            print("max_proposal_size", leader.getProposalStats().getMaxProposalSize());
    -            print("min_proposal_size", leader.getProposalStats().getMinProposalSize());
    +            print("last_proposal_size", leader.getProposalStats().getLast());
    --- End diff --
    
    You're right about stats will evolve with time, but proposal and client request size are
common in Jute buffer usage. I have a strong feeling that these two things will always evolve
together hence it makes sense to keep the stats together which also makes refactoring easier.
Later, if it turns out that they diverge, we can easily split them. 


---

Mime
View raw message