zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...
Date Tue, 17 Apr 2018 15:50:57 GMT
Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/500#discussion_r182128913
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java ---
    @@ -161,8 +127,8 @@ public void testLeaderInConnectingFollowers() throws Exception {
             tmpDir.mkdir();
             Leader leader = null;
             try {
    -            QuorumPeer peer = createQuorumPeer(tmpDir);
    -            leader = createLeader(tmpDir, peer);
    +            QuorumPeer peer = ZabUtils.createQuorumPeer(tmpDir);
    --- End diff --
    
    Agreed, but please don't use asterisk (*) import. We avoid wildcard imports in Zk project.


---

Mime
View raw message