zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rakeshadr <...@git.apache.org>
Subject [GitHub] zookeeper pull request #466: ZOOKEEPER-2940. Deal with maxbuffer as it relat...
Date Mon, 16 Apr 2018 17:39:52 GMT
Github user rakeshadr commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/466#discussion_r181822557
  
    --- Diff: src/java/test/org/apache/zookeeper/server/NIOServerCnxnTest.java ---
    @@ -68,5 +74,19 @@ public void testOperationsAfterCnxnClose() throws IOException,
             } finally {
                 zk.close();
             }
    +
    +    }
    +
    +    @Test
    +    public void testClientResponseStatsUpdate() throws IOException, InterruptedException,
KeeperException {
    +        try (ZooKeeper zk = createClient()) {
    +            ProposalStats stats = serverFactory.getZooKeeperServer().serverStats().getClientResponseStats();
    +            assertEquals("", -1, stats.getLast());
    +
    +            zk.create("/a", "test".getBytes(), Ids.OPEN_ACL_UNSAFE,
    +                    CreateMode.PERSISTENT);
    +
    +            assertThat(stats.getLast(), greaterThan(0));
    --- End diff --
    
    0, looks like magic number. Any possibility to give a non-zero value, matching closer
to the expected value ?
    
    Also, please add error message - assertThat("error message", stats.getLast(), greaterThan(0));



---

Mime
View raw message