zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From edwardoliveira <...@git.apache.org>
Subject [GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count
Date Thu, 12 Apr 2018 15:59:40 GMT
Github user edwardoliveira commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/501#discussion_r181134958
  
    --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
    @@ -55,6 +53,7 @@
         private final File snapDir;
         private TxnLog txnLog;
         private SnapShot snapLog;
    +    private ServerStats serverStats;
    --- End diff --
    
    Maybe I am missing something pretty obvious here, but it seems that `serverStats` is passed
to `FileTxnLog`, but there is no place in this class where it passes `serverStats` to `FileTxnLog`.



---

Mime
View raw message