zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nkalmar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #501: ZOOKEEPER-3019 add metric for slow fsyncs count
Date Thu, 12 Apr 2018 12:32:26 GMT
Github user nkalmar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/501#discussion_r181063500
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
    @@ -32,6 +32,7 @@
         private long minLatency = Long.MAX_VALUE;
         private long totalLatency = 0;
         private long count = 0;
    +    private long fsyncThresholdExceedCount = 0L;
    --- End diff --
    
    Which would also remove the overhead imposed by synchronised. Thanks for the tip, i will
make the changes!


---

Mime
View raw message