From dev-return-68445-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon Mar 26 14:48:56 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1CB23180649 for ; Mon, 26 Mar 2018 14:48:55 +0200 (CEST) Received: (qmail 10189 invoked by uid 500); 26 Mar 2018 12:48:38 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 2468 invoked by uid 99); 26 Mar 2018 12:48:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Mar 2018 12:48:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 1AD9D18030B for ; Mon, 26 Mar 2018 12:48:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id MQpf8tSHus2q for ; Mon, 26 Mar 2018 12:48:33 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D6816670F4 for ; Mon, 26 Mar 2018 09:34:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D1109E0D7F for ; Mon, 26 Mar 2018 09:34:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 395AF214FB for ; Mon, 26 Mar 2018 09:34:00 +0000 (UTC) Date: Mon, 26 Mar 2018 09:34:00 +0000 (UTC) From: "lujie (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (ZOOKEEPER-3010) Potential NPE in Observer#observeLeader and Follower#followLeader MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3010?page=3Dcom.atla= ssian.jira.plugin.system.issuetabpanels:all-tabpanel ] lujie updated ZOOKEEPER-3010: ----------------------------- Description:=20 Inspired by ZK-3006 ,=C2=A0I develop a simple static analysis tool to find = other Potential NPE like ZK-3006. This bug is found by this tool ,and I hav= e carefully studied it.=C2=A0 But i am a=C2=A0newbie at here so i may be wr= ong, hope someone=C2=A0could=C2=A0confirm it and help me=C2=A0improve this = tool. h2. Bug=C2=A0description: callee=C2=A0Learner#findLeader will return null and callee developer check = it but just log: {code:java} // code placeholder if (leaderServer =3D=3D null) { LOG.warn("Couldn't find the leader with id =3D " + current.getId()); } return leaderServer; {code} caller=C2=A0=C2=A0Observer#observeLeader and Follower#followLeader will dir= ectly use return value w/o null check: {code:java} //Follower#followLeader QuorumServer leaderServer =3D findLeader(); try { connectToLeader(leaderServer.addr, leaderServer.hostname); .......... } //Observer#observeLeader QuorumServer leaderServer =3D findLeader(); LOG.info("Observing " + leaderServer.addr); try { connectToLeader(leaderServer.addr, leaderServer.hostname); }{code} was: Inspired by ZK-3006 ,=C2=A0I develop a simple static analysis tool to find = other Potential NPE like ZK-3006. This bug is found by this tool , I carefu= lly studied it,=C2=A0 but i am a=C2=A0newbie here so i may be wrong, hopefu= lly someone can confirm this bug and help me=C2=A0improve this tool. h2. Bug=C2=A0description: callee=C2=A0Learner#findLeader will return null and callee developer check = it but just log: {code:java} // code placeholder if (leaderServer =3D=3D null) { LOG.warn("Couldn't find the leader with id =3D " + current.getId()); } return leaderServer; {code} caller=C2=A0=C2=A0Observer#observeLeader and Follower#followLeader will dir= ectly use return value w/o null check: {code:java} //Follower#followLeader QuorumServer leaderServer =3D findLeader(); try { connectToLeader(leaderServer.addr, leaderServer.hostname); .......... } //Observer#observeLeader QuorumServer leaderServer =3D findLeader(); LOG.info("Observing " + leaderServer.addr); try { connectToLeader(leaderServer.addr, leaderServer.hostname); }{code} > Potential NPE in Observer#observeLeader and Follower#followLeader > ----------------------------------------------------------------- > > Key: ZOOKEEPER-3010 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3010 > Project: ZooKeeper > Issue Type: Bug > Affects Versions: 3.6.0 > Environment: =C2=A0 > =C2=A0 > Reporter: lujie > Priority: Major > > Inspired by ZK-3006 ,=C2=A0I develop a simple static analysis tool to fin= d other Potential NPE like ZK-3006. This bug is found by this tool ,and I h= ave carefully studied it.=C2=A0 But i am a=C2=A0newbie at here so i may be = wrong, hope someone=C2=A0could=C2=A0confirm it and help me=C2=A0improve thi= s tool. > h2. Bug=C2=A0description: > callee=C2=A0Learner#findLeader will return null and callee developer chec= k it but just log: > {code:java} > // code placeholder > if (leaderServer =3D=3D null) { > LOG.warn("Couldn't find the leader with id =3D " + current.getId()); > } > return leaderServer; > {code} > caller=C2=A0=C2=A0Observer#observeLeader and Follower#followLeader will d= irectly use return value w/o null check: > {code:java} > //Follower#followLeader > QuorumServer leaderServer =3D findLeader(); > try { > connectToLeader(leaderServer.addr, leaderServer.hostname); > .......... > } > //Observer#observeLeader > QuorumServer leaderServer =3D findLeader(); > LOG.info("Observing " + leaderServer.addr); > try { > connectToLeader(leaderServer.addr, leaderServer.hostname); > }{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)