From dev-return-68481-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Mar 27 05:13:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 79C5B180649 for ; Tue, 27 Mar 2018 05:13:05 +0200 (CEST) Received: (qmail 78251 invoked by uid 500); 27 Mar 2018 03:13:04 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 78231 invoked by uid 99); 27 Mar 2018 03:13:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Mar 2018 03:13:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id BA6C9C0452 for ; Tue, 27 Mar 2018 03:13:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id sWKrNNFRVns1 for ; Tue, 27 Mar 2018 03:13:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C1D4C5F201 for ; Tue, 27 Mar 2018 03:13:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EE7D9E00E8 for ; Tue, 27 Mar 2018 03:13:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id AAB1221501 for ; Tue, 27 Mar 2018 03:13:00 +0000 (UTC) Date: Tue, 27 Mar 2018 03:13:00 +0000 (UTC) From: "lujie (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (ZOOKEEPER-3009) Potential NPE: class NIOServerCnxn has two method can return null MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16414949#comment-16414949 ]=20 lujie edited comment on ZOOKEEPER-3009 at 3/27/18 3:12 AM: ----------------------------------------------------------- Hi [~andorm] Thinks for your=C2=A0pertinent suggestions. I develop this tool from=C2=A0scratch because:=C2=A0 # I apply=C2=A0 findbugs to check this bug ,=C2=A0 but findbugs leave it o= ut(I assume because it does not perform =C2=A0interprocedural=C2=A0 analysi= s in this check). # i am not=C2=A0=C2=A0very familiar with findbugs and=C2=A0=C2=A0Google's = error prone . # [WALA|https://github.com/wala/WALA](a famous static analysis tool develo= ped by IBM) is my sidekicks, I have developed some static analysis tool bas= ed on=C2=A0 it , so I choose=C2=A0it again. I will try my best to check if findbugs own this rule(eg. callee return nul= l but caller does not check), if not, i will try my best to add this rule. Anyway, I develop this tool based on my finding of zookeeper-3006 and=C2=A0= _[Alibaba Java Coding Guidelines|https://github.com/alibaba/p3c]_=C2=A0whic= h=C2=A0clearly indicates that callee can return null but caller must check = it. On the other hand, massive=C2=A0non-null checker also bother me, just as ta= lk in=C2=A0[Avoiding !=3D null statements|[https://stackoverflow.com/questi= ons/271526/avoiding-null-statements/271874#271874]]=C2=A0. Now i am at the = crossroads(+) =C2=A0 was (Author: xiaoheipangzi): Hi [~andorm] Thinks for your=C2=A0pertinent suggestions. I develop this tool from=C2=A0scratch because:=C2=A0 # I apply=C2=A0 findbugs to check this bug ,=C2=A0 but findbugs leave it o= ut(I assume because it does not perform =C2=A0interprocedural=C2=A0 analysi= s in this check). # i am not=C2=A0=C2=A0very familiar with findbugs and=C2=A0=C2=A0Google's = error prone . # [WALA|https://github.com/wala/WALA](a famous static analysis tool develo= ped by IBM) is my sidekicks, I have developed some static analysis tool bas= ed on=C2=A0 it , so I choose=C2=A0it again. I will try my best to check if findbugs own this rule(eg. callee return nul= l but caller does not check), if not, i will try my best to add this rule. Anyway, I develop this tool based on my finding of zookeeper-3006 and=C2=A0= _[Alibaba Java Coding Guidelines|https://github.com/alibaba/p3c]_=C2=A0whic= h=C2=A0clearly indicates that callee can return null but caller must check = it. On the other hand, massive=C2=A0non-null checker also bother me, just as ta= lk in=C2=A0[Avoiding !=3D null statements|[https://stackoverflow.com/questi= ons/271526/avoiding-null-statements/271874#271874]|https://stackoverflow.co= m/questions/271526/avoiding-null-statements/271874#271874].Now]=C2=A0. Now = i am at the crossroads(+) =C2=A0 > Potential NPE: class NIOServerCnxn has two method can return null > ----------------------------------------------------------------- > > Key: ZOOKEEPER-3009 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3009 > Project: ZooKeeper > Issue Type: Bug > Reporter: lujie > Priority: Major > > Inspired by ZK-3006 ,=C2=A0I develop a simple static analysis tool to fin= d other Potential NPE like ZK-3006. This bug is found by this tool ,and I h= ave carefully studied it.=C2=A0 But i am a=C2=A0newbie at here so i may be = wrong, hope someone=C2=A0could=C2=A0confirm it and help me=C2=A0improve thi= s tool. > h2. Bug=C2=A0description: > =C2=A0class NIOServerCnxn has three method :getSocketAddress,getRemoteSoc= ketAddress can return null just like : > {code:java} > // code placeholder > if (sock.isOpen() =3D=3D false) { > return null; > } > {code} > some of their caller give null checker, some(total 3 list in below) are n= ot.=C2=A0 > {code:java} > // ServerCnxn#getConnectionInfo > Map info =3D new LinkedHashMap(); > info.put("remote_socket_address", getRemoteSocketAddress());// Map.put wi= ll throw NPE if parameter is null > //IPAuthenticationProvider#handleAuthentication > tring id =3D cnxn.getRemoteSocketAddress().getAddress().getHostAddress(); > cnxn.addAuthInfo(new Id(getScheme(), id));// finally call Set.add(it will= throw NPE if parameter is null ) > //NIOServerCnxnFactory#addCnxn > InetAddress addr =3D cnxn.getSocketAddress(); > Set set =3D ipMap.get(addr);// Map.get will throw NPE if p= arameter is null{code} > I think we should add null check in above three caller . > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)