From dev-return-68465-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon Mar 26 17:31:58 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 03ADE180649 for ; Mon, 26 Mar 2018 17:31:57 +0200 (CEST) Received: (qmail 37971 invoked by uid 500); 26 Mar 2018 15:31:57 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 37960 invoked by uid 99); 26 Mar 2018 15:31:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Mar 2018 15:31:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 40708C2C40 for ; Mon, 26 Mar 2018 15:31:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 3cC4nmHRnw3P for ; Mon, 26 Mar 2018 15:31:54 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 10C24639F0 for ; Mon, 26 Mar 2018 13:55:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8589EE0DE5 for ; Mon, 26 Mar 2018 13:55:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 39E36214FD for ; Mon, 26 Mar 2018 13:55:00 +0000 (UTC) Date: Mon, 26 Mar 2018 13:55:00 +0000 (UTC) From: "Andor Molnar (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-3009) Potential NPE: class NIOServerCnxn has two method can return null MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16413879#comment-16413879 ]=20 Andor Molnar commented on ZOOKEEPER-3009: ----------------------------------------- Hi [~xiaoheipangzi] Thanks for the nice contribution, I really appreciate your enthusiasm to de= velop such a handy tool. However, have you checked if it would be possible to similar check with our= existing static analysis tool, findbugs? In addition to that, there's an ongoing effort in [https://github.com/apach= e/zookeeper/pull/490]=C2=A0to integrate Google's error prone compiler for v= ery similar purposes. I'm not sure if you've seen that, but I think it wort= h to consider bringing these existing tools up to speed before implementing= something new from scratch. > Potential NPE: class NIOServerCnxn has two method can return null > ----------------------------------------------------------------- > > Key: ZOOKEEPER-3009 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3009 > Project: ZooKeeper > Issue Type: Bug > Reporter: lujie > Priority: Major > > Inspired by ZK-3006 ,=C2=A0I develop a simple static analysis tool to fin= d other Potential NPE like ZK-3006. This bug is found by this tool ,and I h= ave carefully studied it.=C2=A0 But i am a=C2=A0newbie at here so i may be = wrong, hope someone=C2=A0could=C2=A0confirm it and help me=C2=A0improve thi= s tool. > h2. Bug=C2=A0description: > =C2=A0class NIOServerCnxn has three method :getSocketAddress,getRemoteSoc= ketAddress can return null just like : > {code:java} > // code placeholder > if (sock.isOpen() =3D=3D false) { > return null; > } > {code} > some of their caller give null checker, some(total 3 list in below) are n= ot.=C2=A0 > {code:java} > // ServerCnxn#getConnectionInfo > Map info =3D new LinkedHashMap(); > info.put("remote_socket_address", getRemoteSocketAddress());// Map.put wi= ll throw NPE if parameter is null > //IPAuthenticationProvider#handleAuthentication > tring id =3D cnxn.getRemoteSocketAddress().getAddress().getHostAddress(); > cnxn.addAuthInfo(new Id(getScheme(), id));// finally call Set.add(it will= throw NPE if parameter is null ) > //NIOServerCnxnFactory#addCnxn > InetAddress addr =3D cnxn.getSocketAddress(); > Set set =3D ipMap.get(addr);// Map.get will throw NPE if p= arameter is null{code} > I think we should add null check in above three caller . > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)