From dev-return-68239-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon Mar 19 13:30:08 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A884A180647 for ; Mon, 19 Mar 2018 13:30:07 +0100 (CET) Received: (qmail 41292 invoked by uid 500); 19 Mar 2018 12:30:06 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 41281 invoked by uid 99); 19 Mar 2018 12:30:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Mar 2018 12:30:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 3CD14C00E1 for ; Mon, 19 Mar 2018 12:30:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.561 X-Spam-Level: X-Spam-Status: No, score=-109.561 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_INFOUSMEBIZ=0.75, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id lf_u9nMAlauS for ; Mon, 19 Mar 2018 12:30:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 70D1F5F4E7 for ; Mon, 19 Mar 2018 12:30:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D502DE0D16 for ; Mon, 19 Mar 2018 12:30:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4B077214AC for ; Mon, 19 Mar 2018 12:30:00 +0000 (UTC) Date: Mon, 19 Mar 2018 12:30:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-3000) Use error-prone compiler MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404730#comment-16404730 ] ASF GitHub Bot commented on ZOOKEEPER-3000: ------------------------------------------- Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/490#discussion_r175416977 --- Diff: src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java --- @@ -71,13 +71,14 @@ private void deleteZKDir(ZooKeeper zk, String nodeName) } List children1 = zk.getChildren(nodeName, false); - List c2 = zk.getChildren(nodeName, false, stat); + Stat stat2 = new Stat(); --- End diff -- Which rule has triggered this change? > Use error-prone compiler > ------------------------ > > Key: ZOOKEEPER-3000 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3000 > Project: ZooKeeper > Issue Type: Improvement > Reporter: Roman Leventov > Priority: Major > > See http://errorprone.info/ -- This message was sent by Atlassian JIRA (v7.6.3#76005)