From dev-return-67932-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Mar 2 03:46:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D3F5418067A for ; Fri, 2 Mar 2018 03:46:04 +0100 (CET) Received: (qmail 21474 invoked by uid 500); 2 Mar 2018 02:46:03 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 21315 invoked by uid 99); 2 Mar 2018 02:46:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2018 02:46:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E21611A09BD for ; Fri, 2 Mar 2018 02:46:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id bHIvSY-q0TYn for ; Fri, 2 Mar 2018 02:46:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 14FCC5FAED for ; Fri, 2 Mar 2018 02:46:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9A263E023A for ; Fri, 2 Mar 2018 02:46:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3121824765 for ; Fri, 2 Mar 2018 02:46:00 +0000 (UTC) Date: Fri, 2 Mar 2018 02:46:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-2936) Duplicate Keys in log4j.properties config files MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383060#comment-16383060 ] ASF GitHub Bot commented on ZOOKEEPER-2936: ------------------------------------------- Github user asutosh936 commented on the issue: https://github.com/apache/zookeeper/pull/473 @anmolnar - Could You or someone from Your team please merge this PR? > Duplicate Keys in log4j.properties config files > ----------------------------------------------- > > Key: ZOOKEEPER-2936 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2936 > Project: ZooKeeper > Issue Type: Bug > Components: contrib, other > Affects Versions: 3.4.8 > Environment: Apache ZooKeeper source tarball > Reporter: Hari Sekhon > Priority: Trivial > > Recent versions of ZooKeeper have introduced the following duplicate keys in to the contrib log4j.properties files. > In this file: > {code} > ./zookeeper-3.4.8/contrib/rest/conf/log4j.properties > {code} > and this file: > {code} > ./zookeeper-3.4.8/src/contrib/rest/conf/log4j.properties > {code} > the following duplicate keys are found: > {code} > log4j.appender.ROLLINGFILE.layout=org.apache.log4j.PatternLayout > log4j.appender.ROLLINGFILE.layout.ConversionPattern=%d{ISO8601} - %-5p [%t:%C{1}@%L] - %m%n > {code} > This was discovered because I've written file validators for most major formats which recurse all my github repos and this was failing my integration tests when pulling ZooKeeper source code. I actually added --exclude and --ignore-duplicate-keys switches to {code}validate_ini.py{code} to work around this and fix my builds for now but just remembered to raise this to you guys. > The validator tools if you're interested can be found at: > https://github.com/harisekhon/pytools > Cheers > Hari -- This message was sent by Atlassian JIRA (v7.6.3#76005)