From dev-return-68513-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Wed Mar 28 11:11:03 2018
Return-Path: <dev-return-68513-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 92A32180652
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 28 Mar 2018 11:11:02 +0200 (CEST)
Received: (qmail 73026 invoked by uid 500); 28 Mar 2018 09:11:01 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 72978 invoked by uid 99); 28 Mar 2018 09:11:00 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Mar 2018 09:11:00 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id F0B44F64DE; Wed, 28 Mar 2018 09:10:59 +0000 (UTC)
From: LJ1043041006 <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-496-zookeeper@git.apache.org>
In-Reply-To: <git-pr-496-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuth...
Content-Type: text/plain
Message-Id: <20180328091059.F0B44F64DE@git1-us-west.apache.org>
Date: Wed, 28 Mar 2018 09:10:59 +0000 (UTC)

Github user LJ1043041006 commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/496#discussion_r177685103
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java ---
    @@ -94,7 +94,7 @@ public void authenticate(Socket sock, String hostName) throws IOException {
                         principalConfig,
                         QuorumAuth.QUORUM_SERVER_PROTOCOL_NAME,
                         QuorumAuth.QUORUM_SERVER_SASL_DIGEST, LOG, "QuorumLearner");
    -
    +            // may happen NPE at here
                 if (sc.hasInitialResponse()) {
                     responseToken = createSaslToken(new byte[0], sc, learnerLogin);
    --- End diff --
    
    just add sc!=null is ok?


---