From dev-return-68428-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon Mar 26 11:30:14 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DC5C4180649 for ; Mon, 26 Mar 2018 11:30:13 +0200 (CEST) Received: (qmail 33105 invoked by uid 500); 26 Mar 2018 09:30:12 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 33081 invoked by uid 99); 26 Mar 2018 09:30:12 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Mar 2018 09:30:12 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 50D48F0BE4; Mon, 26 Mar 2018 09:30:11 +0000 (UTC) From: anmolnar To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper issue #490: ZOOKEEPER-3000: Use error-prone compiler Content-Type: text/plain Message-Id: <20180326093011.50D48F0BE4@git1-us-west.apache.org> Date: Mon, 26 Mar 2018 09:30:11 +0000 (UTC) Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/490 @leventov I've just verified your patch on my local machine. Is Java8 a requirement for error-prone to work? Because running `ant clean test` with java7 I got the following error message: > BUILD FAILED /Users/andor/git/my-zookeeper/build.xml:1417: The following error occurred while executing this line: /Users/andor/git/my-zookeeper/build.xml:490: Class com.google.errorprone.ErrorProneAntCompilerAdapter could not be loaded because of an invalid dependency. If that's the case, I'm afraid we can only merge this patch to master, once we upgraded to java8 which is coming soon, but not there yet. Additionally running with Java8 I got 75 warning messages. Is that accurate? ---