From dev-return-68227-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon Mar 19 11:56:26 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 42331180647 for ; Mon, 19 Mar 2018 11:56:26 +0100 (CET) Received: (qmail 32257 invoked by uid 500); 19 Mar 2018 10:56:25 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 32241 invoked by uid 99); 19 Mar 2018 10:56:24 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Mar 2018 10:56:24 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id AE9A4F3332; Mon, 19 Mar 2018 10:56:23 +0000 (UTC) From: anmolnar To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper issue #488: ZOOKEEPER-2993 - Removed 'generated' line from .gitign... Content-Type: text/plain Message-Id: <20180319105623.AE9A4F3332@git1-us-west.apache.org> Date: Mon, 19 Mar 2018 10:56:23 +0000 (UTC) Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/488 @afine In the other way around: if there's no '/' at the beginning of the keyword, git will check the entire path relative to the root for the string `generated` and if it finds a match, it'll ignore all files underneath. My suggestion is to remove `generated` keyword from .gitignore - like in this PR -, because 'real' generated folders are already excluded explicitly. There could be other possible solutions to the problem, I'm open to them. ---