From dev-return-68219-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Mon Mar 19 11:27:50 2018
Return-Path: <dev-return-68219-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 77924180647
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 19 Mar 2018 11:27:49 +0100 (CET)
Received: (qmail 61650 invoked by uid 500); 19 Mar 2018 10:27:48 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 61639 invoked by uid 99); 19 Mar 2018 10:27:47 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Mar 2018 10:27:47 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 8C213F4E18; Mon, 19 Mar 2018 10:27:47 +0000 (UTC)
From: anmolnar <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-492-zookeeper@git.apache.org>
In-Reply-To: <git-pr-492-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #492: ZOOKEEPER-3001: Incorrect log message when try ...
Content-Type: text/plain
Message-Id: <20180319102747.8C213F4E18@git1-us-west.apache.org>
Date: Mon, 19 Mar 2018 10:27:47 +0000 (UTC)

Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/492#discussion_r175386273
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ContainerManager.java ---
    @@ -116,8 +116,8 @@ public void checkContainers()
                 Request request = new Request(null, 0, 0,
                         ZooDefs.OpCode.deleteContainer, path, null);
                 try {
    -                LOG.info("Attempting to delete candidate container: %s",
    -                        containerPath);
    +                LOG.info(String.format("Attempting to delete candidate container: %s",
    --- End diff --
    
    +1 for @eribeiro 
    We already use that form at various places in the codebase, so feel free to use the better one. Existing String.formats should be refactored in the long term, but that probably will happen in small refactorings like this.


---