From dev-return-67946-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Fri Mar  2 22:58:06 2018
Return-Path: <dev-return-67946-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id E595418062F
	for <archive-asf-public@cust-asf.ponee.io>; Fri,  2 Mar 2018 22:58:05 +0100 (CET)
Received: (qmail 29862 invoked by uid 500); 2 Mar 2018 21:58:03 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 29058 invoked by uid 99); 2 Mar 2018 21:58:03 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2018 21:58:03 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 196EDF4DD6; Fri,  2 Mar 2018 21:58:01 +0000 (UTC)
From: afine <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-476-zookeeper@git.apache.org>
In-Reply-To: <git-pr-476-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #476: ZOOKEEPER-2988: NPE triggered if server receive...
Content-Type: text/plain
Message-Id: <20180302215802.196EDF4DD6@git1-us-west.apache.org>
Date: Fri,  2 Mar 2018 21:58:01 +0000 (UTC)

Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/476#discussion_r171970721
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
    @@ -1012,4 +1012,113 @@ public void testFailedTxnAsPartOfQuorumLoss() throws Exception {
                 Assert.assertNull("server " + i + " should not have /zk" + leader, servers.zk[i].exists("/zk" + leader, false));
             }
         }
    +
    +    /**
    +     * Verify that a node without the leader in its view will not attempt to connect to the leader.
    +     */
    +    @Test
    +    public void testLeaderOutOfView() throws Exception {
    +        ClientBase.setupTestEnv();
    +
    +        Layout layout = new PatternLayout("%d{ISO8601} [,yid:%X{myid}] - %5p [%t:%C{1}@%L] - %m%n");
    --- End diff --
    
    It would be great if we did not specify the pattern as a literal. Take a look at some of the other tests and see if the way they get the patternlayout could apply here (`testElectionFraud` for example).


---