zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andschwa <...@git.apache.org>
Subject [GitHub] zookeeper pull request #483: ZOOKEEPER-2997: CMake should not force static C...
Date Fri, 09 Mar 2018 21:03:05 GMT
GitHub user andschwa opened a pull request:

    https://github.com/apache/zookeeper/pull/483

    ZOOKEEPER-2997: CMake should not force static CRT linking

    By removing this code, CMake will use its own defaults for the CRT
    flags (e.g., `/MDd` for debug configurations). With it removed, the
    user can override this behavior by setting the `CMAKE_CXX_FLAGS`
    manually when configuring ZooKeeper.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andschwa/zookeeper master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/483.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #483
    
----
commit 45a997ad0e281d967460f4eb205a4b18e4219ecd
Author: Andrew Schwartzmeyer <andrew@...>
Date:   2018-03-09T21:00:48Z

    ZOOKEEPER-2997: CMake should not force static CRT linking
    
    By removing this code, CMake will use its own defaults for the CRT
    flags (e.g., `/MDd` for debug configurations). With it removed, the
    user can override this behavior by setting the `CMAKE_CXX_FLAGS`
    manually when configuring ZooKeeper.

----


---

Mime
View raw message