zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "lujie (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (ZOOKEEPER-3009) Potential NPE: class NIOServerCnxn has two method can return null
Date Mon, 26 Mar 2018 09:34:00 GMT

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

lujie updated ZOOKEEPER-3009:
-----------------------------
    Description: 
Inspired by ZK-3006 , I develop a simple static analysis tool to find other Potential NPE
like ZK-3006. This bug is found by this tool ,and I have carefully studied it.  But i am
a newbie at here so i may be wrong, hope someone could confirm it and help me improve
this tool.
h2. Bug description:

 class NIOServerCnxn has three method :getSocketAddress,getRemoteSocketAddress can return
null just like :
{code:java}
// code placeholder
if (sock.isOpen() == false) {
  return null;
}
{code}
some of their caller give null checker, some(total 3 list in below) are not. 
{code:java}
// ServerCnxn#getConnectionInfo
Map<String, Object> info = new LinkedHashMap<String, Object>();
info.put("remote_socket_address", getRemoteSocketAddress());// Map.put will throw NPE if parameter
is null

//IPAuthenticationProvider#handleAuthentication
tring id = cnxn.getRemoteSocketAddress().getAddress().getHostAddress();
cnxn.addAuthInfo(new Id(getScheme(), id));// finally call Set.add(it will throw NPE if parameter
is null )

//NIOServerCnxnFactory#addCnxn
InetAddress addr = cnxn.getSocketAddress();
Set<NIOServerCnxn> set = ipMap.get(addr);// Map.get will throw NPE if parameter is null{code}
I think we should add null check in above three caller .

 

  was:
Inspired by ZK-3006, I develop a simple static analysis tool to find other Potential NPE
like ZK-3006. This bug is found by this tool , I carefully studied it,  but i am a newbie
here so i may be wrong, hopefully someone can confirm this bug and help me improve this tool.
h2. Bug description:

 class NIOServerCnxn has three method :getSocketAddress,getRemoteSocketAddress can return
null just like :
{code:java}
// code placeholder
if (sock.isOpen() == false) {
  return null;
}
{code}
some of their caller give null checker, some(total 3 list in below) are not. 
{code:java}
// ServerCnxn#getConnectionInfo
Map<String, Object> info = new LinkedHashMap<String, Object>();
info.put("remote_socket_address", getRemoteSocketAddress());// Map.put will throw NPE if parameter
is null

//IPAuthenticationProvider#handleAuthentication
tring id = cnxn.getRemoteSocketAddress().getAddress().getHostAddress();
cnxn.addAuthInfo(new Id(getScheme(), id));// finally call Set.add(it will throw NPE if parameter
is null )

//NIOServerCnxnFactory#addCnxn
InetAddress addr = cnxn.getSocketAddress();
Set<NIOServerCnxn> set = ipMap.get(addr);// Map.get will throw NPE if parameter is null{code}
I think we should add null check in above three caller .

 


> Potential NPE: class NIOServerCnxn has two method can return null
> -----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-3009
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3009
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: lujie
>            Priority: Major
>
> Inspired by ZK-3006 , I develop a simple static analysis tool to find other Potential
NPE like ZK-3006. This bug is found by this tool ,and I have carefully studied it.  But i
am a newbie at here so i may be wrong, hope someone could confirm it and help me improve
this tool.
> h2. Bug description:
>  class NIOServerCnxn has three method :getSocketAddress,getRemoteSocketAddress can return
null just like :
> {code:java}
> // code placeholder
> if (sock.isOpen() == false) {
>   return null;
> }
> {code}
> some of their caller give null checker, some(total 3 list in below) are not. 
> {code:java}
> // ServerCnxn#getConnectionInfo
> Map<String, Object> info = new LinkedHashMap<String, Object>();
> info.put("remote_socket_address", getRemoteSocketAddress());// Map.put will throw NPE
if parameter is null
> //IPAuthenticationProvider#handleAuthentication
> tring id = cnxn.getRemoteSocketAddress().getAddress().getHostAddress();
> cnxn.addAuthInfo(new Id(getScheme(), id));// finally call Set.add(it will throw NPE if
parameter is null )
> //NIOServerCnxnFactory#addCnxn
> InetAddress addr = cnxn.getSocketAddress();
> Set<NIOServerCnxn> set = ipMap.get(addr);// Map.get will throw NPE if parameter
is null{code}
> I think we should add null check in above three caller .
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message