zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-3000) Use error-prone compiler
Date Tue, 20 Mar 2018 14:08:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406384#comment-16406384
] 

ASF GitHub Bot commented on ZOOKEEPER-3000:
-------------------------------------------

Github user maoling commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/490#discussion_r175772100
  
    --- Diff: src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java ---
    @@ -266,7 +282,7 @@ synchronized public void removeInstance(String name) throws InterruptedException
             if (assigned == null) {
                 return;
             }
    -        assignments.get(assigned.container).remove(name);
    +        assignments.get(assigned.container).remove(new Assigned(name, 0));
             doDelete(assignmentsNode + '/' + assigned.container + '/' + name);
    --- End diff --
    
    +1


> Use error-prone compiler
> ------------------------
>
>                 Key: ZOOKEEPER-3000
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3000
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Roman Leventov
>            Priority: Major
>
> See http://errorprone.info/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message