zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-3000) Use error-prone compiler
Date Mon, 19 Mar 2018 10:53:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404630#comment-16404630
] 

ASF GitHub Bot commented on ZOOKEEPER-3000:
-------------------------------------------

Github user mfenes commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/490#discussion_r175393694
  
    --- Diff: build.xml ---
    @@ -475,23 +484,36 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
                         pattern="${ivy.lib}/[artifact]-[revision].[ext]"/>
           <ivy:cachepath pathid="mvn-ant-task-classpath" conf="mvn-ant-task"/>
         </target>
    -    <target name="compile" depends="ivy-retrieve,clover,build-generated">
    -        <javac srcdir="${java.src.dir}" destdir="${build.classes}" includeantruntime="false"
    +    <target name="compile" depends="ivy-retrieve,clover,build-generated,ivy-retrieve-error_prone">
    --- End diff --
    
    Could we add the error prone compiler as an optional tool, so that similarly to e.g. code
coverage tools, the build could be run with or without the tool?


> Use error-prone compiler
> ------------------------
>
>                 Key: ZOOKEEPER-3000
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3000
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Roman Leventov
>            Priority: Major
>
> See http://errorprone.info/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message