zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-3000) Use error-prone compiler
Date Mon, 26 Mar 2018 10:28:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413658#comment-16413658
] 

ASF GitHub Bot commented on ZOOKEEPER-3000:
-------------------------------------------

Github user leventov commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/490#discussion_r177043995
  
    --- Diff: src/java/test/org/apache/zookeeper/test/AsyncHammerTest.java ---
    @@ -61,6 +61,7 @@ protected void restart() throws Exception {
             qb.startServers();
         }
     
    +    @SuppressWarnings("JUnit4TearDownNotRun")
    --- End diff --
    
    I would keep it as is for symmetry with setup() method, that couldn't be declared `@Before`
because it has a parameter.


> Use error-prone compiler
> ------------------------
>
>                 Key: ZOOKEEPER-3000
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3000
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Roman Leventov
>            Priority: Major
>
> See http://errorprone.info/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message