zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2997) CMake should not force static CRT linking
Date Fri, 09 Mar 2018 21:18:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393603#comment-16393603
] 

ASF GitHub Bot commented on ZOOKEEPER-2997:
-------------------------------------------

Github user andschwa commented on the issue:

    https://github.com/apache/zookeeper/pull/485
  
    I had to reopen this because I changed which branch it was from.


> CMake should not force static CRT linking
> -----------------------------------------
>
>                 Key: ZOOKEEPER-2997
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2997
>             Project: ZooKeeper
>          Issue Type: Bug
>         Environment: Windows
>            Reporter: Andrew Schwartzmeyer
>            Assignee: Andrew Schwartzmeyer
>            Priority: Major
>
> When writing the CMake build, I erroneously forced ZooKeeper to link to the Windows CRT
statically. Instead of setting this, we should rely on CMake's defaults, and let users override
it if they choose to by configuring with  setting {{CMAKE_CXX_ARGS}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message