zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2997) CMake should not force static CRT linking
Date Mon, 26 Mar 2018 06:03:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413408#comment-16413408
] 

ASF GitHub Bot commented on ZOOKEEPER-2997:
-------------------------------------------

Github user andschwa commented on the issue:

    https://github.com/apache/zookeeper/pull/485
  
    Thanks @hanm!


> CMake should not force static CRT linking
> -----------------------------------------
>
>                 Key: ZOOKEEPER-2997
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2997
>             Project: ZooKeeper
>          Issue Type: Bug
>         Environment: Windows
>            Reporter: Andrew Schwartzmeyer
>            Assignee: Andrew Schwartzmeyer
>            Priority: Major
>             Fix For: 3.5.4, 3.6.0
>
>
> When writing the CMake build, I erroneously forced ZooKeeper to link to the Windows CRT
statically. Instead of setting this, we should rely on CMake's defaults, and let users override
it if they choose to by configuring with  setting {{CMAKE_CXX_ARGS}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message