zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2993) .ignore file prevents adding src/java/main/org/apache/jute/compiler/generated dir to git repo
Date Thu, 15 Mar 2018 19:46:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401016#comment-16401016
] 

ASF GitHub Bot commented on ZOOKEEPER-2993:
-------------------------------------------

Github user jason95 commented on the issue:

    https://github.com/apache/zookeeper/pull/488
  
    Hi folks,
    
    Sorry for not keeping up with the jira.
    @asutosh936 - thanks for the PR and others for reviewing.
    
    Here are some info - hope it will shed some clarity.
    
    - There exists in the repo/source code a dir named: src/java/main/org/apache/jute/compiler/generated
    - In that dir it has Rcc.java and other files
    - Files in that dir is required to for successful compilation
    
    - However, the .gitignore has the keyword "generated"
    - when I add the source code tree into out company repo, the src/java/main/org/apache/jute/compiler/generated
was effectively ignored - and thus not added into our company repo
    - I ran a jenkins job to compile the code from the repo - it failed - due to the missing
Rcc and other required java sources under that excluded directory.
    
    When I did a git status - everything was in sync even though my workspace has the Rcc.java
- but my company repo actually is missing that dir.  My local compile succeeds every time.
 But jenkins job compile using company repo always fails.  After some comparison - then I
noticed the missing dir on the company repo side.
    
    Once I removed the generated keyword from the .gitignore - git immediately detected the
generated dir in my workspace as new.  I was able to git add/commit/push to make the jenkins
compile successful.
    
    Hope this help clarify the situation.
    
    I prefer to have generated keyword removed.  In the future, if the compile will generate
artifacts that should be ignored, then modify the .gitignore and rename the src/java/main/org/apache/jute/compiler/generated
dir - so the 2 does not conflict.
    
    My 2 cents.
    
    Thanks



> .ignore file prevents adding src/java/main/org/apache/jute/compiler/generated dir to
git repo
> ---------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2993
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2993
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.4.10
>            Reporter: jason wang
>            Priority: Minor
>
> There are Rcc.java and other required files under the src/java/main/org/apache/jute/compiler/generated
directory.
> However, when I tried to add the source distribution to our own git repo, the .gitignore
file has "generated" as a key word in line 55 - which prevents the dir and files under that
dir to be added to the repo.  The compilation later fails due to the missing dir and files.
> *compile_jute*
>  :*19:02:54* [mkdir] Created dir: /home/jenkins/workspace/3PA/PMODS/zookeeper-pgdi-patch-in-maven-repo/src/java/generated*
> 19:02:54* [mkdir] Created dir: /home/jenkins/workspace/3PA/PMODS/zookeeper-pgdi-patch-in-maven-repo/src/c/generated*
> 19:02:54* [java] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
> *19:02:54* [java] Error: Could not find or load main class org.apache.jute.compiler.generated.Rcc*
> 19:02:54* [java] Java Result: 1*19:02:54* [java] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
> *19:02:54* [java] Error: Could not find or load main class org.apache.jute.compiler.generated.Rcc*
> 19:02:54* [java] Java Result: 1*19:02:54* [touch] Creating /home/jenkins/workspace/3PA/PMODS/zookeeper-pgdi-patch-in-maven-repo/src/java/generated/.generated*
>  
> Fix is to remove or comment out the generated key word in line 55.
> #
>  #generated
>  #
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message