zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2993) .ignore file prevents adding src/java/main/org/apache/jute/compiler/generated dir to git repo
Date Thu, 15 Mar 2018 18:18:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400891#comment-16400891
] 

ASF GitHub Bot commented on ZOOKEEPER-2993:
-------------------------------------------

Github user afine commented on the issue:

    https://github.com/apache/zookeeper/pull/488
  
    @asutosh936 I agree with @anmolnar That directory exists, it is currently in version control,
and I don't think any generated files actually end up there. My guess is that it is there
purely for historical reasons and to contain the rcc.jj file.
    
    In other words, I don't think your change to the gitignore will impact that directory.
According to the gitignore documentation (https://git-scm.com/docs/gitignore):
    
    > If the pattern does not contain a slash /, Git treats it as a shell glob pattern
and checks for a match against the pathname relative to the location of the .gitignore file
(relative to the toplevel of the work tree if not from a .gitignore file).
    
    Since there are not any top level files called `generated` I don't think this line in
the gitignore has any impact on the repository. Am I missing something here?
    



> .ignore file prevents adding src/java/main/org/apache/jute/compiler/generated dir to
git repo
> ---------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2993
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2993
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.4.10
>            Reporter: jason wang
>            Priority: Minor
>
> There are Rcc.java and other required files under the src/java/main/org/apache/jute/compiler/generated
directory.
> However, when I tried to add the source distribution to our own git repo, the .gitignore
file has "generated" as a key word in line 55 - which prevents the dir and files under that
dir to be added to the repo.  The compilation later fails due to the missing dir and files.
> *compile_jute*
>  :*19:02:54* [mkdir] Created dir: /home/jenkins/workspace/3PA/PMODS/zookeeper-pgdi-patch-in-maven-repo/src/java/generated*
> 19:02:54* [mkdir] Created dir: /home/jenkins/workspace/3PA/PMODS/zookeeper-pgdi-patch-in-maven-repo/src/c/generated*
> 19:02:54* [java] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
> *19:02:54* [java] Error: Could not find or load main class org.apache.jute.compiler.generated.Rcc*
> 19:02:54* [java] Java Result: 1*19:02:54* [java] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
> *19:02:54* [java] Error: Could not find or load main class org.apache.jute.compiler.generated.Rcc*
> 19:02:54* [java] Java Result: 1*19:02:54* [touch] Creating /home/jenkins/workspace/3PA/PMODS/zookeeper-pgdi-patch-in-maven-repo/src/java/generated/.generated*
>  
> Fix is to remove or comment out the generated key word in line 55.
> #
>  #generated
>  #
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message