zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2993) .ignore file prevents adding src/java/main/org/apache/jute/compiler/generated dir to git repo
Date Wed, 14 Mar 2018 21:04:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16399406#comment-16399406
] 

ASF GitHub Bot commented on ZOOKEEPER-2993:
-------------------------------------------

Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/488
  
    @tamaashu Generally speaking I agree with you, but that directory is somewhat different.
There is code in it which we don't generate during our build process, but it's been in git
since the beginning of ZooKeeper.
    I have no idea why that directory named 'generated'. It's quite misleading.
    @afine @tamaashu please take a closer look before making a judgement.



> .ignore file prevents adding src/java/main/org/apache/jute/compiler/generated dir to
git repo
> ---------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2993
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2993
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.4.10
>            Reporter: jason wang
>            Priority: Minor
>
> There are Rcc.java and other required files under the src/java/main/org/apache/jute/compiler/generated
directory.
> However, when I tried to add the source distribution to our own git repo, the .gitignore
file has "generated" as a key word in line 55 - which prevents the dir and files under that
dir to be added to the repo.  The compilation later fails due to the missing dir and files.
> *compile_jute*
>  :*19:02:54* [mkdir] Created dir: /home/jenkins/workspace/3PA/PMODS/zookeeper-pgdi-patch-in-maven-repo/src/java/generated*
> 19:02:54* [mkdir] Created dir: /home/jenkins/workspace/3PA/PMODS/zookeeper-pgdi-patch-in-maven-repo/src/c/generated*
> 19:02:54* [java] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
> *19:02:54* [java] Error: Could not find or load main class org.apache.jute.compiler.generated.Rcc*
> 19:02:54* [java] Java Result: 1*19:02:54* [java] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
> *19:02:54* [java] Error: Could not find or load main class org.apache.jute.compiler.generated.Rcc*
> 19:02:54* [java] Java Result: 1*19:02:54* [touch] Creating /home/jenkins/workspace/3PA/PMODS/zookeeper-pgdi-patch-in-maven-repo/src/java/generated/.generated*
>  
> Fix is to remove or comment out the generated key word in line 55.
> #
>  #generated
>  #
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message