zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andor Molnar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2990) Implement probabilistic tracing
Date Mon, 05 Mar 2018 14:37:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386142#comment-16386142
] 

Andor Molnar commented on ZOOKEEPER-2990:
-----------------------------------------

My suggestions:
 # Per mask would be the best I would say. It's the most sophisticated.
 # I can't see a reason why not to add it to existing 4lw ('stmk'). Currently it's a special
case of 1.0 probability for all trace messages, so the probability values could be an optional
parameter of the existing command. However you could face some difficulties adding such a
lot of new values to the command input nicely.
 # Agreed. They should use a shortcut in ZooTrace meaning: log at trace level with 1.0 probability.

 

> Implement probabilistic tracing
> -------------------------------
>
>                 Key: ZOOKEEPER-2990
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2990
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Bogdan Kanivets
>            Assignee: Bogdan Kanivets
>            Priority: Minor
>
> It would be nice to have an ability to do probabilistic tracing similar to Cassandra 
[nodetool|https://docs.datastax.com/en/dse/5.1/dse-admin/datastax_enterprise/tools/nodetool/toolsSetTraceProbability.html]
> This will help debug issues in prod systems.
> I'd like to contribute if everyone is ok with the feature.
> My suggestion is to add an extra parameter to ZooTrace to handle it. Questions:
>  * should it be one global param or per each ZooTrace mask? I'm thinking per mask
>  * should it be a new 4lw or part of 'stmk'? Leaning towards new word and refactoring
param passing to words (stmk is a special case right now).
>  * there are places in the code that use LOG.trace directly. That will have to change
to ZooTrace
> I can make some initial implementation for demo/review.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message