zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuth...
Date Wed, 28 Mar 2018 09:59:33 GMT
Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/496#discussion_r177697912
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java
---
    @@ -134,6 +138,8 @@ public void authenticate(Socket sock, String hostName) throws IOException
{
     
                 // Validate status code at the end of authentication exchange.
                 checkAuthStatus(sock, qpStatus);
    +        } catch (RuntimeException e) {
    --- End diff --
    
    @brettKK What's the point of swallowing it here?


---

Mime
View raw message