zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From LJ1043041006 <...@git.apache.org>
Subject [GitHub] zookeeper pull request #496: ZOOKEEPER-3008: Potential NPE in SaslQuorumAuth...
Date Wed, 28 Mar 2018 09:10:59 GMT
Github user LJ1043041006 commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/496#discussion_r177685103
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthLearner.java
---
    @@ -94,7 +94,7 @@ public void authenticate(Socket sock, String hostName) throws IOException
{
                         principalConfig,
                         QuorumAuth.QUORUM_SERVER_PROTOCOL_NAME,
                         QuorumAuth.QUORUM_SERVER_SASL_DIGEST, LOG, "QuorumLearner");
    -
    +            // may happen NPE at here
                 if (sc.hasInitialResponse()) {
                     responseToken = createSaslToken(new byte[0], sc, learnerLogin);
    --- End diff --
    
    just add sc!=null is ok?


---

Mime
View raw message