zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maoling <...@git.apache.org>
Subject [GitHub] zookeeper pull request #490: ZOOKEEPER-3000: Use error-prone compiler
Date Tue, 20 Mar 2018 14:07:16 GMT
Github user maoling commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/490#discussion_r175774472
  
    --- Diff: src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java ---
    @@ -71,13 +71,14 @@ private void deleteZKDir(ZooKeeper zk, String nodeName)
         }
     
         List<String> children1 = zk.getChildren(nodeName, false);
    -    List<String> c2 = zk.getChildren(nodeName, false, stat);
    +    Stat stat2 = new Stat();
    +    List<String> c2 = zk.getChildren(nodeName, false, stat2);
    --- End diff --
    
    **stat** has been changed(copyed) in **zk.getChildren()** .   `stat.equals(stat) `is right
in findbugs


---

Mime
View raw message