zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From leventov <...@git.apache.org>
Subject [GitHub] zookeeper pull request #490: ZOOKEEPER-3000: Use error-prone compiler
Date Mon, 19 Mar 2018 20:11:29 GMT
Github user leventov commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/490#discussion_r175569277
  
    --- Diff: src/java/test/org/apache/zookeeper/test/AsyncHammerTest.java ---
    @@ -61,6 +61,7 @@ protected void restart() throws Exception {
             qb.startServers();
         }
     
    +    @SuppressWarnings("JUnit4TearDownNotRun")
    --- End diff --
    
    Because it's called from test bodies directly. I've fixed that by making the methods private
instead of adding suppression.


---

Mime
View raw message