zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #492: ZOOKEEPER-3001: Incorrect log message when try ...
Date Mon, 19 Mar 2018 10:27:47 GMT
Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/492#discussion_r175386273
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ContainerManager.java ---
    @@ -116,8 +116,8 @@ public void checkContainers()
                 Request request = new Request(null, 0, 0,
                         ZooDefs.OpCode.deleteContainer, path, null);
                 try {
    -                LOG.info("Attempting to delete candidate container: %s",
    -                        containerPath);
    +                LOG.info(String.format("Attempting to delete candidate container: %s",
    --- End diff --
    
    +1 for @eribeiro 
    We already use that form at various places in the codebase, so feel free to use the better
one. Existing String.formats should be refactored in the long term, but that probably will
happen in small refactorings like this.


---

Mime
View raw message