zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sel-fish <...@git.apache.org>
Subject [GitHub] zookeeper pull request #492: ZOOKEEPER-3001: Incorrect log message when try ...
Date Mon, 19 Mar 2018 00:55:28 GMT
Github user sel-fish commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/492#discussion_r175313093
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ContainerManager.java ---
    @@ -116,8 +116,8 @@ public void checkContainers()
                 Request request = new Request(null, 0, 0,
                         ZooDefs.OpCode.deleteContainer, path, null);
                 try {
    -                LOG.info("Attempting to delete candidate container: %s",
    -                        containerPath);
    +                LOG.info(String.format("Attempting to delete candidate container: %s",
    --- End diff --
    
    to use the same logging style as the other code.
    
                    LOG.error(String.format("Could not delete container: %s" ,
                            containerPath), e);


---

Mime
View raw message