zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jason95 <...@git.apache.org>
Subject [GitHub] zookeeper issue #488: ZOOKEEPER-2993 - Removed 'generated' line from .gitign...
Date Thu, 15 Mar 2018 19:45:38 GMT
Github user jason95 commented on the issue:

    https://github.com/apache/zookeeper/pull/488
  
    Hi folks,
    
    Sorry for not keeping up with the jira.
    @asutosh936 - thanks for the PR and others for reviewing.
    
    Here are some info - hope it will shed some clarity.
    
    - There exists in the repo/source code a dir named: src/java/main/org/apache/jute/compiler/generated
    - In that dir it has Rcc.java and other files
    - Files in that dir is required to for successful compilation
    
    - However, the .gitignore has the keyword "generated"
    - when I add the source code tree into out company repo, the src/java/main/org/apache/jute/compiler/generated
was effectively ignored - and thus not added into our company repo
    - I ran a jenkins job to compile the code from the repo - it failed - due to the missing
Rcc and other required java sources under that excluded directory.
    
    When I did a git status - everything was in sync even though my workspace has the Rcc.java
- but my company repo actually is missing that dir.  My local compile succeeds every time.
 But jenkins job compile using company repo always fails.  After some comparison - then I
noticed the missing dir on the company repo side.
    
    Once I removed the generated keyword from the .gitignore - git immediately detected the
generated dir in my workspace as new.  I was able to git add/commit/push to make the jenkins
compile successful.
    
    Hope this help clarify the situation.
    
    I prefer to have generated keyword removed.  In the future, if the compile will generate
artifacts that should be ignored, then modify the .gitignore and rename the src/java/main/org/apache/jute/compiler/generated
dir - so the 2 does not conflict.
    
    My 2 cents.
    
    Thanks



---

Mime
View raw message