zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From asutosh936 <...@git.apache.org>
Subject [GitHub] zookeeper issue #488: ZOOKEEPER-2993 - Removed 'generated' line from .gitign...
Date Tue, 13 Mar 2018 01:12:03 GMT
Github user asutosh936 commented on the issue:

    https://github.com/apache/zookeeper/pull/488
  
    @anmolnar @afine - Thank You for the review comments.
    
    The change is to remove 'generated' keyword from .gitignore because it prevents the dir
and files under generated dir to be added to the repo.  The compilation later fails due to
the missing dir and files.
    
    Also I am trying to squash the previous commits but somehow git is not allowing me to
do so. Let me know if the changes looks good and to be merged or I need to close this PR and
create new one.


---

Mime
View raw message