zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper issue #475: Fixed PurgeTxnLog params order in the zkCleanup.sh
Date Thu, 01 Mar 2018 14:15:20 GMT
Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/475
  
    I had a look at the code and it seems to me that previous ordering of parameters was right.

    
    `FileTxnSnapLog` class is instantiated from `PurgeTxnLog` by parsing the 0. cli arg to
`dataDir` (== txn log dir) and 1. cli arg to `snapDir` (==snapshot dir). 
    
    So, basically the right order of cli args is _logdir_ and _snapdir_.
    
    Would you please clarify what have you experienced exactly when you said _without that
it did nothing_?


---

Mime
View raw message