zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rakeshadr <...@git.apache.org>
Subject [GitHub] zookeeper issue #474: ZOOKEEPER-2977: Concurrency for addAuth corrupts quoru...
Date Thu, 01 Mar 2018 11:12:00 GMT
Github user rakeshadr commented on the issue:

    https://github.com/apache/zookeeper/pull/474
  
    @sumitagrawl Good analysis and fix. Few minor comments,
    - Please take care indentation in the tests.  Presently, it uses tab.
    - Please add comments in test as a quick reference to the issue to show the expectations
and background of this test,  something like, https://github.com/apache/zookeeper/blob/master/src/java/test/org/apache/zookeeper/server/DataTreeTest.java#L70
    - break; is not needed in loop, pls remove.



---

Mime
View raw message