From dev-return-67651-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Feb 16 23:48:07 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 87E1E180647 for ; Fri, 16 Feb 2018 23:48:06 +0100 (CET) Received: (qmail 47705 invoked by uid 500); 16 Feb 2018 22:48:05 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 47694 invoked by uid 99); 16 Feb 2018 22:48:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Feb 2018 22:48:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id BE2451800CF for ; Fri, 16 Feb 2018 22:48:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id fi8nV6kheqER for ; Fri, 16 Feb 2018 22:48:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id BC0DA5F5FB for ; Fri, 16 Feb 2018 22:48:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 03A4DE0309 for ; Fri, 16 Feb 2018 22:48:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6A90A21E63 for ; Fri, 16 Feb 2018 22:48:00 +0000 (UTC) Date: Fri, 16 Feb 2018 22:48:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-2967) Add check to validate dataDir and dataLogDir parameters at startup MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16367972#comment-16367972 ]=20 ASF GitHub Bot commented on ZOOKEEPER-2967: ------------------------------------------- Github user mfenes commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/459#discussion_r168889616 =20 --- Diff: src/java/test/org/apache/zookeeper/test/ClientBase.java --- @@ -351,20 +351,37 @@ static void verifyThreadTerminated(Thread thread,= long millis) } } =20 + public static File createEmptyTestDir() throws IOException { + return createTmpDir(BASETEST, false); + } =20 public static File createTmpDir() throws IOException { - return createTmpDir(BASETEST); + return createTmpDir(BASETEST, true); } - static File createTmpDir(File parentDir) throws IOException { + + static File createTmpDir(File parentDir, boolean createInitFile) t= hrows IOException { File tmpFile =3D File.createTempFile("test", ".junit", parentD= ir); // don't delete tmpFile - this ensures we don't attempt to cre= ate // a tmpDir with a duplicate name File tmpDir =3D new File(tmpFile + ".dir"); Assert.assertFalse(tmpDir.exists()); // never true if tmpfile = does it's job Assert.assertTrue(tmpDir.mkdirs()); =20 + // todo not every tmp directory needs this file --- End diff -- =20 Unfortunately this todo comment is in the master branch from where I ba= ckported these changes in ClientBase. > Add check to validate dataDir and dataLogDir parameters at startup > ------------------------------------------------------------------ > > Key: ZOOKEEPER-2967 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2967 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Affects Versions: 3.4.11 > Reporter: Andor Molnar > Assignee: Mark Fenes > Priority: Major > Labels: startup, validation > Fix For: 3.5.4, 3.6.0, 3.4.12 > > > According to=C2=A0 -ZOOKEEPER-2960-=C2=A0we should at a startup check to = validate that dataDir and dataLogDir parameters are set correctly. > Perhaps we should introduce a check of some kind? If datalogdir is differ= ent that datadir and snapshots exist in datalogdir we throw an exception an= d quit. -- This message was sent by Atlassian JIRA (v7.6.3#76005)