From dev-return-67868-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon Feb 26 19:34:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5E38518064A for ; Mon, 26 Feb 2018 19:34:04 +0100 (CET) Received: (qmail 91544 invoked by uid 500); 26 Feb 2018 18:34:03 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 91533 invoked by uid 99); 26 Feb 2018 18:34:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Feb 2018 18:34:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B085B1802F9 for ; Mon, 26 Feb 2018 18:34:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id XFBoFU2GcPvB for ; Mon, 26 Feb 2018 18:34:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2AD505F17D for ; Mon, 26 Feb 2018 18:34:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6886FE014A for ; Mon, 26 Feb 2018 18:34:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 10966255CE for ; Mon, 26 Feb 2018 18:34:00 +0000 (UTC) Date: Mon, 26 Feb 2018 18:34:00 +0000 (UTC) From: "William L Thomson Jr (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-2399) Partial Initial Patches to update Zookeeper trunk to Netty 4.x API MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377335#comment-16377335 ] William L Thomson Jr commented on ZOOKEEPER-2399: ------------------------------------------------- Turns out it was not to bad, and really does not seem like anything has changed in those classes since I did the work. The rebase conflicts were minor. Just removing old code, in place of new really. This time I uploaded the changes to a netty4 branch https://github.com/Obsidian-StudiosInc/zookeeper/tree/netty4 Patch format https://github.com/Obsidian-StudiosInc/zookeeper/commit/d97cda5b944ed57136841b3dd27312be818d668d.patch Diff format https://github.com/Obsidian-StudiosInc/zookeeper/commit/d97cda5b944ed57136841b3dd27312be818d668d.diff Those should cleanly apply, but still needs work. Aspects of Zookeeper may need recoding for Netty 4.x. Pretty sure I was using Netty 4.1.x, not 4.0.x. No point to 4.0.x IMHO, best to go to 4.1.x. Rather than 3.x, which it currently uses from org.jboss.netty, pre netty.io starting in 4.x. > Partial Initial Patches to update Zookeeper trunk to Netty 4.x API > ------------------------------------------------------------------ > > Key: ZOOKEEPER-2399 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2399 > Project: ZooKeeper > Issue Type: Improvement > Reporter: William L Thomson Jr > Priority: Major > Attachments: ClientCnxnSocketNetty_java.patch, NettyServerCnxnFactory_java.patch, NettyServerCnxn_java.patch > > > These are initial patches to update Zookeeper to Netty 4.x API. They are not complete, as I am not familiar with Zookeeper or Netty. I just used Netty documents that detailed the difference in the API to make the changes. I believe I am 80-90% of the way there, but need someone familiar with Zookeeper and/or Netty to finish the last part and make sure it actually works and I did not fubar Zookeeper :) -- This message was sent by Atlassian JIRA (v7.6.3#76005)