From dev-return-67547-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Feb 15 18:42:10 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 861FA18064A for ; Thu, 15 Feb 2018 18:42:09 +0100 (CET) Received: (qmail 97397 invoked by uid 500); 15 Feb 2018 17:42:03 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 97360 invoked by uid 99); 15 Feb 2018 17:42:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Feb 2018 17:42:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 02627C040D for ; Thu, 15 Feb 2018 17:42:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id kNihB9pfrZ7O for ; Thu, 15 Feb 2018 17:42:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 896975F4EB for ; Thu, 15 Feb 2018 17:42:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 17625E00D9 for ; Thu, 15 Feb 2018 17:42:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5D1A621E68 for ; Thu, 15 Feb 2018 17:42:00 +0000 (UTC) Date: Thu, 15 Feb 2018 17:42:00 +0000 (UTC) From: "Alexander Shraer (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-1990) suspicious instantiation of java Random instances MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-1990?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16365999#comment-16365999 ]=20 Alexander Shraer commented on ZOOKEEPER-1990: --------------------------------------------- Oh, I see that I already wrote the same above 4 years ago. Time flies=C2=A0= :) > suspicious instantiation of java Random instances > ------------------------------------------------- > > Key: ZOOKEEPER-1990 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1990 > Project: ZooKeeper > Issue Type: Bug > Affects Versions: 3.5.0 > Reporter: Patrick Hunt > Assignee: Mark Fenes > Priority: Critical > Fix For: 3.5.4, 3.6.0 > > > It's not clear to me why we are doing this, but it looks very suspicious.= Why aren't we just calling "new Random()" in these cases? (even for the te= sts I don't really see it - typically that would just be for repeatability) > {noformat} > ag "new Random[ \t]*\(" . > src/java/main/org/apache/zookeeper/ClientCnxn.java > 817: private Random r =3D new Random(System.nanoTime()); =20 > src/java/main/org/apache/zookeeper/client/StaticHostProvider.java > 75: sourceOfRandomness =3D new Random(System.currentTimeMillis() ^ = this.hashCode()); > 98: sourceOfRandomness =3D new Random(randomnessSeed); > src/java/main/org/apache/zookeeper/server/quorum/AuthFastLeaderElection.j= ava > 420: rand =3D new Random(java.lang.Thread.currentThread().= getId() > src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java > 64: private final Random r =3D new Random(System.nanoTime()); > src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java > 537: Random r =3D new Random(id ^ superSecret); > 554: Random r =3D new Random(sessionId ^ superSecret); > src/java/test/org/apache/zookeeper/server/quorum/WatchLeakTest.java > 271: Random r =3D new Random(SESSION_ID ^ superSecret); > src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java > 151: Random rand =3D new Random(Thread.currentThread().getId()= ); > 258: Random rand =3D new Random(Thread.currentThread().getId()= ); > 288: Random rand =3D new Random(Thread.currentThread().getId()); > src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java > 40: private Random r =3D new Random(1); > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)