From dev-return-67434-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Feb 13 04:20:07 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 9C810180652 for ; Tue, 13 Feb 2018 04:20:07 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8C3DE160C61; Tue, 13 Feb 2018 03:20:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D1CCF160C3F for ; Tue, 13 Feb 2018 04:20:06 +0100 (CET) Received: (qmail 28173 invoked by uid 500); 13 Feb 2018 03:20:05 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 28154 invoked by uid 99); 13 Feb 2018 03:20:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Feb 2018 03:20:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 1C4BF1A0B84 for ; Tue, 13 Feb 2018 03:20:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id LtHsfi9WJGh2 for ; Tue, 13 Feb 2018 03:20:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 21CEB5F640 for ; Tue, 13 Feb 2018 03:20:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A469FE0153 for ; Tue, 13 Feb 2018 03:20:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id CB2C021E80 for ; Tue, 13 Feb 2018 03:20:02 +0000 (UTC) Date: Tue, 13 Feb 2018 03:20:00 +0000 (UTC) From: "Ted Yu (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (ZOOKEEPER-1859) pwriter should be closed in NIOServerCnxn#checkFourLetterWord() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated ZOOKEEPER-1859: ------------------------------ Description: {code} final PrintWriter pwriter = new PrintWriter( new BufferedWriter(new SendBufferWriter())); ... } else if (len == telnetCloseCmd) { cleanupWriterSocket(null); return true; } {code} pwriter should be closed in case of telnetCloseCmd was: {code} final PrintWriter pwriter = new PrintWriter( new BufferedWriter(new SendBufferWriter())); ... } else if (len == telnetCloseCmd) { cleanupWriterSocket(null); return true; } {code} pwriter should be closed in case of telnetCloseCmd > pwriter should be closed in NIOServerCnxn#checkFourLetterWord() > --------------------------------------------------------------- > > Key: ZOOKEEPER-1859 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1859 > Project: ZooKeeper > Issue Type: Bug > Reporter: Ted Yu > Priority: Minor > > {code} > final PrintWriter pwriter = new PrintWriter( > new BufferedWriter(new SendBufferWriter())); > ... > } else if (len == telnetCloseCmd) { > cleanupWriterSocket(null); > return true; > } > {code} > pwriter should be closed in case of telnetCloseCmd -- This message was sent by Atlassian JIRA (v7.6.3#76005)