From dev-return-67446-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Feb 13 13:22:55 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 5FB47180656 for ; Tue, 13 Feb 2018 13:22:55 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 4F527160C53; Tue, 13 Feb 2018 12:22:55 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 95AC9160C50 for ; Tue, 13 Feb 2018 13:22:54 +0100 (CET) Received: (qmail 87034 invoked by uid 500); 13 Feb 2018 12:22:53 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 87019 invoked by uid 99); 13 Feb 2018 12:22:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Feb 2018 12:22:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 80F161800D6 for ; Tue, 13 Feb 2018 12:22:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.728 X-Spam-Level: X-Spam-Status: No, score=0.728 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.249, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id MLhkKyTMRHUp for ; Tue, 13 Feb 2018 12:22:51 +0000 (UTC) Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 7CB955F180 for ; Tue, 13 Feb 2018 12:22:51 +0000 (UTC) Received: by mail-wm0-f51.google.com with SMTP id i186so15638728wmi.4 for ; Tue, 13 Feb 2018 04:22:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:date:references:to:in-reply-to:message-id; bh=9rfx/XmfxIgm+E23/gqCqlv2+ZGlnG80tHRexjAAIBk=; b=at97vwGWcedLCi7qzE583rtClPKZAsVPWDcNeZVDGVGqLXJfVetoeeAWYTK6xrI+Je MOpo7uycTRi6CxX5M3koyyRVZp2viaglSzuAzxBKCr/kE2+EHvOmJJC69/xGUTvJTAOO nOfJtrfcyz5wx9oUMD+sBxJmUe09hO2d6eLKo3PqmoQ11+fMi+NIRftxDP/JqWbTHPoY mcJPX+qTVJy5pBRc3m/AWH5pVRWZE1lYbtd4FS/gKACaYmdw2+XlNrxhdO22i4KzYD3o WJxZC7x0io/4f9hrFR1i8M23Bg1NFG2ueJeyMjFlm8xRoIajjLBYqdOjbZ5pcpo8QILC Ut4A== X-Gm-Message-State: APf1xPAtaPOQMOcqMpQcdU39PeN/iUyXHF0ixN7kJP+HFgW6WnrKo8gC DxHHGHnFd/qfSdU1J0ad+040hjwV X-Google-Smtp-Source: AH8x227Aen7iqMf2seLV1G39eTYLbnJ6JROtWd7c0KrOpiKllffsvRi+bZhdqsJVyB0ca1eVaYhw+w== X-Received: by 10.28.2.68 with SMTP id 65mr1113268wmc.60.1518524570958; Tue, 13 Feb 2018 04:22:50 -0800 (PST) Received: from [192.168.1.53] ([80.31.94.197]) by smtp.gmail.com with ESMTPSA id r6sm2212364wrg.88.2018.02.13.04.22.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Feb 2018 04:22:50 -0800 (PST) From: Flavio Junqueira Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: Review request for ZOOKEEPER-2845 Date: Tue, 13 Feb 2018 13:22:47 +0100 References: To: dev@zookeeper.apache.org In-Reply-To: Message-Id: <3826C878-0400-4F0C-9AD0-74241A725E62@apache.org> X-Mailer: Apple Mail (2.3273) Give me some time to catch up with the discussion thread in the issue, = please. -Flavio > On 5 Feb 2018, at 15:43, Bobby Evans wrote: >=20 > I was really hoping to get a review for ZOOKEEPER-2845 >=20 > https://github.com/apache/zookeeper/pull/453 (master) > https://github.com/apache/zookeeper/pull/454 (3.5 line) > https://github.com/apache/zookeeper/pull/455 (3.4 line) >=20 > The bug was exposed by changes made in ZOOKEEPER-2678 which went into > 3.4.10. > There is a real, although rare, possibility of data corruption and = because > ZooKeeper is mission critical to so many other projects I would love = to get > this in before 3.4.12 is released. >=20 > Thanks, >=20 > Bobby Evans