From dev-return-67618-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Feb 16 16:57:51 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A66B6180647 for ; Fri, 16 Feb 2018 16:57:50 +0100 (CET) Received: (qmail 59176 invoked by uid 500); 16 Feb 2018 15:57:49 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 59157 invoked by uid 99); 16 Feb 2018 15:57:48 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Feb 2018 15:57:48 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id C7C3BE0779; Fri, 16 Feb 2018 15:57:48 +0000 (UTC) From: revans2 To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper pull request #453: ZOOKEEPER-2845: Apply commit log when restartin... Content-Type: text/plain Message-Id: <20180216155748.C7C3BE0779@git1-us-west.apache.org> Date: Fri, 16 Feb 2018 15:57:48 +0000 (UTC) Github user revans2 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/453#discussion_r168795646 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -435,7 +435,7 @@ private void waitForOne(ZooKeeper zk, States state) throws InterruptedException int iterations = ClientBase.CONNECTION_TIMEOUT / 500; while (zk.getState() != state) { if (iterations-- == 0) { - throw new RuntimeException("Waiting too long"); + throw new RuntimeException("Waiting too long " + zk.getState() + " != " + state); --- End diff -- @anmolnar and @afine I put this in for my own debugging and I forgot to remove it. If you want me to I am happy to either remove it or file a separate JIRA and put it up as a separate pull request, or just leave it. Either way is fine with me. ---