From dev-return-67522-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Wed Feb 14 21:46:19 2018
Return-Path: <dev-return-67522-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id E5377180656
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 14 Feb 2018 21:46:18 +0100 (CET)
Received: (qmail 53727 invoked by uid 500); 14 Feb 2018 20:46:17 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 53035 invoked by uid 99); 14 Feb 2018 20:46:17 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Feb 2018 20:46:17 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 61D2FDFBBB; Wed, 14 Feb 2018 20:46:16 +0000 (UTC)
From: eolivelli <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-457-zookeeper@git.apache.org>
In-Reply-To: <git-pr-457-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #457: ZOOKEEPER-1534: ZookeeperServer now returns Aut...
Content-Type: text/plain
Message-Id: <20180214204616.61D2FDFBBB@git1-us-west.apache.org>
Date: Wed, 14 Feb 2018 20:46:16 +0000 (UTC)

Github user eolivelli commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/457#discussion_r168302873
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
    @@ -1101,8 +1102,16 @@ public void processPacket(ServerCnxn cnxn, ByteBuffer incomingBuffer) throws IOE
             } else {
                 if (h.getType() == OpCode.sasl) {
                     Record rsp = processSasl(incomingBuffer,cnxn);
    -                ReplyHeader rh = new ReplyHeader(h.getXid(), 0, KeeperException.Code.OK.intValue());
    -                cnxn.sendResponse(rh,rsp, "response"); // not sure about 3rd arg..what is it?
    +                if (rsp == null) {
    +                    ReplyHeader rh = new ReplyHeader(h.getXid(), 0, Code.AUTHFAILED.intValue());
    +                    cnxn.sendResponse(rh, new SetSASLResponse(AUTHENTICATION_FAILED.getBytes()), "response"); // not sure about 3rd arg..what is it?
    +                    LOG.warn("Closing client connection due to SASL authentication failure.");
    --- End diff --
    
    Can we log at least the ip address of the client?


---