zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2967) Add check to validate dataDir and dataLogDir parameters at startup
Date Fri, 02 Feb 2018 00:02:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349541#comment-16349541

ASF GitHub Bot commented on ZOOKEEPER-2967:

Github user mfenes commented on the issue:

    @afine I've made the following changes:
    Replaced "log" and "snapshot" strings with constants FileTxnLog.LOG_FILE_PREFIX and FileSnap.SNAPSHOT_FILE_PREFIX.
    Used Util.makeLogName when creating new transaction log file to make sure creation and
verification follows the same file name pattern. 
    Added reference to ZOOKEEPER-2967 to explain why this check is needed.
    Cleaned up/refactored unit test FileTxnSnapLogTest to make it less verbose and consistent.

> Add check to validate dataDir and dataLogDir parameters at startup
> ------------------------------------------------------------------
>                 Key: ZOOKEEPER-2967
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2967
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.4.11
>            Reporter: Andor Molnar
>            Assignee: Mark Fenes
>            Priority: Major
>              Labels: startup, validation
>             Fix For: 3.5.4, 3.6.0, 3.4.12
> According to  -ZOOKEEPER-2960- we should at a startup check to validate that dataDir
and dataLogDir parameters are set correctly.
> Perhaps we should introduce a check of some kind? If datalogdir is different that datadir
and snapshots exist in datalogdir we throw an exception and quit.

This message was sent by Atlassian JIRA

View raw message