zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2901) Session ID that is negative causes mis-calculation of Ephemeral Type
Date Wed, 07 Feb 2018 23:14:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16356218#comment-16356218
] 

ASF GitHub Bot commented on ZOOKEEPER-2901:
-------------------------------------------

Github user phunt commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/377#discussion_r166787489
  
    --- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
    @@ -950,6 +952,39 @@ server.3=zoo3:2888:3888</programlisting>
                 </listitem>
               </varlistentry>
     
    +          <varlistentry>
    +            <term>zookeeper.extendedTypesEnabled</term>
    +
    +            <listitem>
    +                <para>(Java system property only: <emphasis
    +                    role="bold">zookeeper.extendedTypesEnabled</emphasis>)</para>
    +
    +              <para><emphasis role="bold">New in 3.5.4, 3.6.0:</emphasis>
Define to "true" to enable
    +              extended features such as the creation of <ulink url="zookeeperProgrammers.html#TTL+Nodes">TTL
Nodes</ulink>.
    +              They are disabled by default. IMPORTANT: when enabled server IDs must
    +              be less than 255 due to internal limitations.
    +              </para>
    +            </listitem>
    +          </varlistentry>
    +
    +          <varlistentry>
    +            <term>zookeeper.emulate353TTLNodes</term>
    --- End diff --
    
    What's the plan for deprecating this? Keeping this parameter around forever seems like
a bad idea. Adds complication that we don't really need to carry around. Perhaps we can deprecate
in 3.5.4 and remove in 3.5.5? Similarly I don't think we should include this at all in 3.6.0
(trunk).


> Session ID that is negative causes mis-calculation of Ephemeral Type
> --------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2901
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2901
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.5.3
>         Environment: Running 3.5.3-beta in Docker container
>            Reporter: Mark Johnson
>            Assignee: Jordan Zimmerman
>            Priority: Blocker
>
> In the code that determines the EphemeralType it is looking at the owner (which is the
client ID or connection ID):
> EphemeralType.java:
>    public static EphemeralType get(long ephemeralOwner) {
>        if (ephemeralOwner == CONTAINER_EPHEMERAL_OWNER) {
>            return CONTAINER;
>        }
>        if (ephemeralOwner < 0) {
>            return TTL;
>        }
>        return (ephemeralOwner == 0) ? VOID : NORMAL;
>    }
> However my connection ID is:
> header.getClientId(): -720548323429908480
> This causes the code to think this is a TTL Ephemeral node instead of a
> NORMAL Ephemeral node.
> This also explains why this is random - if my client ID is non-negative
> then the node gets added correctly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message