zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #453: ZOOKEEPER-2845: Apply commit log when restartin...
Date Fri, 16 Feb 2018 00:59:03 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/453#discussion_r168649080
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java ---
    @@ -435,7 +435,7 @@ private void waitForOne(ZooKeeper zk, States state) throws InterruptedException
             int iterations = ClientBase.CONNECTION_TIMEOUT / 500;
             while (zk.getState() != state) {
                 if (iterations-- == 0) {
    -                throw new RuntimeException("Waiting too long");
    +                throw new RuntimeException("Waiting too long " + zk.getState() + " !=
" + state);
    --- End diff --
    
    nit: let's minimize unrelated test changes and whitespace changes


---

Mime
View raw message